Note to Self: Handling a Pull Request
May 07, 2024 18:15
David Jones MVP
devops
devops
cplusplus
07 May 2024 18:15:06
David Jones MVP
devops devops cplusplus
devops devops cplusplus
Accepting a PR on GitHub
So you have had a Pull Request from someone wrt your repository. How to check it out before accepting it. Also, a C++ compilation error plus its answer.
- Get the Pull Request Id.
- Go to the Pull Request in GitHub
- Look for the hash number in the PR title.
- eg
Adding blockly examples #4
- PR Id is 4 in this case.
- Make clean clone of the repository
- Run the following command in the cloned directory:
git fetch origin pull/4/head && git checkout FETCH_HEAD
- The 4 is replaced by the PR Id.
- Build and run this version of the repository and note any follow up changes you think needed.
- Accept the Pull Request in GitHub.
- Go back to your original copy of the repository and sync it.
- Make the changes you deemed required from 3.
- Push those updates back to the repository.
- Delete the test directory.
A compilation error: C++ programming
default argument given for parameter 1
You are probably redefining the default parameter in the implementation of the function. It should only be defined in the function declaration. 2nd answer here
Where you define a class in a header file, only put default parameters there. Don’t also put in the source file.
Topic | Subtopic | |
Next: > | Softata | A 74HC595 Shift Register Class |
< Prev: | Arduino | Build Issue - Multiple definition of an entity |
This Category Links | ||
Category: | DevOps Index: | DevOps |